Code Review

Workflow

• When a feature is ready for review, we need to create a pull request on github to assign the developer who will make the code review in oue project.
• The code reviewer need to check the files changes in the pull request to review the code.
• If the Code Review is Approved: the code reviewer will comment on the pull request "Code Review is OK".
• If the Code Review is not Approved: the code reviwer will comment on the pull request "Code Review is not OK" and need to change the PR to request changes and the developer need to check the code again a fix the suggetions make it by the code reviwer.
• When the code review is OK: the developer will merge the pull request to requested the branch to continue the work.

Checklist

• The commit files for code review will cannot exceed 700 lines of code. If it's the case the developer need to make a comment to explain why this file is too big. There is exceptions for minified files and config files.
• Code review time need to be no more than 30min. If the code review need more time, notify the developer who assigned you the code review.
• In the code review process make suggetions and no demands (!important).
• Follow the project standard created by the team, sometimes this can found the CODE-STANTARD.md or CONTRIBUTING.md files in the repo.
• Pull Request must contains: Ticket ID, Ticket URL, Assined developer request for Code Review.
• Tickets on Jira must contains: Pull Request URL, Assigned Developer for Code review.
• Track your time as INTERNAL in the time tracking company document and log your as Code Review in the Jira Issue.

Code Review Calendar

Weekly code review schedule is generated every Monday on the tracker app.